Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally use prologue in test_vjp_correctness #1438

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conditionally use prologue in test_vjp_correctness #1438

merged 3 commits into from
Nov 18, 2024
+19 −5

Conversation

beverlylytle
Copy link
Collaborator

@beverlylytle beverlylytle commented Nov 14, 2024 •
edited
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

CI times increased significantly with #1427. This aims to reduce CI times by only including the prologue for ops with kwargs.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@beverlylytle beverlylytle changed the title DRAFT/WIP -- not up for review Conditionally use prologue in test_vjp_correctness Nov 14, 2024
@beverlylytle beverlylytle marked this pull request as ready for review November 14, 2024 11:39
@t-vi t-vi enabled auto-merge (squash) November 14, 2024 17:15
t-vi
t-vi approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @beverlylytle

@t-vi t-vi merged commit d60f85c into main Nov 18, 2024
41 checks passed
@t-vi t-vi deleted the check_vjp_kwargs branch November 18, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beverlylytle @t-vi